Give a vulnerability somewhere private to go - #32
Merged
Conversation
The Security tab was empty: no policy, no private reporting, no scanning. A repository that has just gone public and asks users for their own Spotify and Last.fm credentials should not leave a finder's only options as a public issue or an email address they have to guess. SECURITY.md names the reporting channel and, more usefully, says what is worth looking at: track metadata is untrusted input that reaches ffmpeg arguments, file names and directory paths; sign-in is PKCE with no client secret; the refresh token is DPAPI-protected and the Last.fm key deliberately is not; and the routing interop marshals HSTRINGs by hand, where memory-safety mistakes are plausible in a way they are not elsewhere in managed code. CodeQL runs on Ubuntu with build-mode: none, which reads C# without compiling it — the only arrangement that can scan a Windows-only WPF app on a Linux runner. Private reporting, Dependabot alerts and updates, and secret scanning with push protection were enabled on the repository itself. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Security tab was empty — no policy, no private reporting, no scanning. A repository that has just gone public, and that asks users to supply their own Spotify and Last.fm credentials, shouldn't leave a finder's only options as a public issue or an email address they have to guess.
In this PR
SECURITY.md— where to report (private vulnerability reporting, not an issue), what's supported (main; there are no releases yet), and what actually deserves attention: track metadata is untrusted input that reaches ffmpeg arguments, file names and directory paths; sign-in is PKCE with no client secret and a validatedstate; the refresh token is DPAPI-protected and the access token never touches disk; the routing interop marshals HSTRINGs by hand, where memory-safety mistakes are plausible in a way they aren't elsewhere in managed code. Plus what's deliberate — the Last.fm key is plain text insettings.json, being a read-only key for a public catalogue that belongs to the user..github/workflows/codeql.yml— C#, the workflows themselves, and the one Python script, on pushes tomain, on PRs, and weekly. Ubuntu withbuild-mode: none, deliberately: the analysis extracts C# without compiling it, so it needs neither WPF nor the Windows SDK nor a WASAPI-capable machine. Building it on that runner is the one step that could not work.Already enabled on the repository (API, not in this diff)
Non-provider patterns and validity checks stayed off — those are GitHub Advanced Security features, not available on this plan.
🤖 Generated with Claude Code